extending propercasing to legacy clusters, header sanitization to all routes#1621
Merged
alyssawilk merged 3 commits intoenvoyproxy:mainfrom Jul 27, 2021
Merged
extending propercasing to legacy clusters, header sanitization to all routes#1621alyssawilk merged 3 commits intoenvoyproxy:mainfrom
alyssawilk merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
changed the title
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
|
Restarting the failed tests. |
goaway
approved these changes
Jul 26, 2021
Contributor
goaway
left a comment
goaway
left a comment
There was a problem hiding this comment.
Looks good; let's see if the tests go through this time around.
Augustyniak
pushed a commit
to Augustyniak/envoy-mobile
that referenced
this pull request
Aug 2, 2021
… routes (envoyproxy#1621) Risk Level: medium hopefully addresses envoyproxy#1558 and envoyproxy#1557 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
buildbreaker
pushed a commit
that referenced
this pull request
Aug 17, 2021
…n to all routes (#1621)" (#1710) * Revert "extending propercasing to legacy clusters, header sanitization to all routes (#1621)" This reverts commit 6e507d3. Signed-off-by: Alan Chiu <achiu@lyft.com> * ignore test Signed-off-by: Alan Chiu <achiu@lyft.com> * codespell Signed-off-by: Alan Chiu <achiu@lyft.com>
buildbreaker
pushed a commit
that referenced
this pull request
Aug 18, 2021
…n to all routes (#1621)" (#1710) * Revert "extending propercasing to legacy clusters, header sanitization to all routes (#1621)" This reverts commit 6e507d3. Signed-off-by: Alan Chiu <achiu@lyft.com> * ignore test Signed-off-by: Alan Chiu <achiu@lyft.com> * codespell Signed-off-by: Alan Chiu <achiu@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk Level: medium
hopefully addresses #1558 and #1557